feat(cart): Add cart module package

[olivermrbl]

What
Adds Cart Module package @medusajs/cart

Whether to stick with jest or replace with node's built-in testing tools (from v20) is to be discussed

Resolves CORE-1609

[changeset-bot]

🦋 Changeset detected

Latest commit: f90940c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
api-reference	⬜️ Ignored (Inspect)	Visit Preview		Jan 2, 2024 2:35pm
docs-ui	⬜️ Ignored (Inspect)	Visit Preview		Jan 2, 2024 2:35pm
medusa-docs	⬜️ Ignored (Inspect)	Visit Preview		Jan 2, 2024 2:35pm

[olivermrbl]

comment: These scripts seem to contain a lot of duplicated code with little to no changes across modules. We should consider a refactor to eliminate the amount of boilerplate code

[adrien2p]

I believe we can create utils function to build those script and export them from the modules

[olivermrbl]

I have left out the migration until I start integration testing

[olivermrbl]

@riqwan @pKorsholm, did any of you experience issues with building medusa-react after adding the new package? I find it strange that these changes affect that package. Am I missing something trivial?

[adrien2p]

LGTM, Maybe you can include a util proposal for the script in a later pr? or create a ticket that we can handle

[fPolic]

@olivermrbl I had the same build issue on my SC module PR.

[olivermrbl]

I had the same build issue on my SC module PR

How did you resolve it?

[fPolic]

I fixed the line it's complaining about but it is strange.

[riqwan]

LGTM! 🎉

[adrien2p]

I have left out the migration until I start integration testing

Seems true, indeed the function does not return something all the time. In some cases it will return Promise<unknown> | unknown and on other cases it will return void. though, it should also fail on dev right?

[riqwan]

@olivermrbl should this require a changeset for the other packages thats affected here?

[olivermrbl]

should this require a changeset for the other packages thats affected here?

Yes, nice catch. Will include it

[fPolic]

LGTM!