-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move next admin packages to core repo #5983
Conversation
🦋 Changeset detectedLatest commit: bcb0554 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
…dusajs/medusa into chore/move-admin-next-version
…dusajs/medusa into chore/move-admin-next-version
Yes, albeit with two caveats as per the changesets docs:
But I think we can manage. Alternatively, we do as with the modules packages and just never include them in changesets. Or thirdly, add |
const mergedConfig = deepmerge(config1, config2) | ||
mergedConfig.content = mergedContent | ||
|
||
console.log(config1.presets, config2.presets) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log(config1.presets, config2.presets) |
} | ||
|
||
if (!auth.user) { | ||
console.log("redirecting"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log("redirecting"); |
I think you might be missing prettier files to eliminate the semi-colons |
Is this a long-running PR? I thought the idea was to merge this, so we can do the follow-up changes in "reviewable" chunks. Happy to do either approach. |
Merging now, I just didn't want to stop work until this was merged, but moving forward each piece of work will be one PR. |
…dusajs/medusa into chore/move-admin-next-version
What
next
version of admin to core repoOther