fix(medusa): cart completion payment sessions #5995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b15af5c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
|
just need to fix the unit |
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/admin-ui@2.1.11-snapshot-20240104123142yarn add @medusajs/core-flows@0.0.4-snapshot-20240104123142yarn add @medusajs/link-modules@0.2.6-snapshot-20240104123142yarn add @medusajs/medusa@1.19.1-snapshot-20240104123142yarn add medusa-fulfillment-manual@1.1.39-snapshot-20240104123142yarn add medusa-fulfillment-webshipper@1.4.2-snapshot-20240104123142yarn add medusa-interfaces@1.3.8-snapshot-20240104123142yarn add @medusajs/medusa-js@6.1.5-snapshot-20240104123142yarn add medusa-payment-adyen@1.1.45-snapshot-20240104123142yarn add medusa-payment-stripe@6.0.7-snapshot-20240104123142yarn add medusa-react@9.0.13-snapshot-20240104123142yarn add medusa-test-utils@1.1.41-snapshot-20240104123142yarn add @medusajs/modules-sdk@1.12.6-snapshot-20240104123142yarn add @medusajs/orchestration@0.5.2-snapshot-20240104123142yarn add @medusajs/pricing@0.1.7-snapshot-20240104123142yarn add @medusajs/product@0.3.7-snapshot-20240104123142yarn add @medusajs/types@1.11.10-snapshot-20240104123142yarn add @medusajs/utils@1.11.3-snapshot-20240104123142yarn add @medusajs/workflows-sdk@0.1.1-snapshot-20240104123142
|
…dusa into fix/cart-completion-sessions
olivermrbl
approved these changes
Jan 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix cart completion, we have included the set payment sessions to ensure the payment sessions at the moment of the completion. But this includes some issues depending on the way the payment is being captured depending on the provider but also the kind of payment method that is being used. Rolling back seems for now the best solution.
related discussion:
https://discord.com/channels/876835651130097704/1192115812241256448
https://discord.com/channels/876835651130097704/1192145003632402452
https://discord.com/channels/876835651130097704/1192140832078319717