Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cart): Public-facing DTOs + (partial) module interface #6000

Merged
merged 27 commits into from
Jan 10, 2024
Merged

feat(cart): Public-facing DTOs + (partial) module interface #6000

merged 27 commits into from
Jan 10, 2024

Conversation

olivermrbl
Copy link
Contributor

@olivermrbl olivermrbl commented Jan 4, 2024 •
edited
Loading

Awaiting #5986

What

  • Add types for cart mutations
  • Add module service interface with CRUD

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 91314cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 11:59am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2024 11:59am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2024 11:59am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2024 11:59am

@olivermrbl olivermrbl changed the base branch from feat/cart-module-data-models to develop January 5, 2024 17:35
@olivermrbl olivermrbl changed the title [wip] feat(cart): Public-facing DTOs + (partial) module interface feat(cart): Public-facing DTOs + (partial) module interface Jan 5, 2024
@olivermrbl olivermrbl marked this pull request as ready for review January 5, 2024 17:36
@olivermrbl olivermrbl requested a review from a team as a code owner January 5, 2024 17:36
This was referenced Jan 6, 2024
Closed
Merged
adrien2p
adrien2p reviewed Jan 8, 2024
View reviewed changes
packages/types/src/cart/common.ts Outdated Show resolved Hide resolved
packages/types/src/cart/common.ts Outdated Show resolved Hide resolved
packages/types/src/cart/common.ts Outdated Show resolved Hide resolved
packages/types/src/cart/common.ts Show resolved Hide resolved
packages/types/src/cart/common.ts Outdated Show resolved Hide resolved
packages/types/src/cart/mutations.ts Show resolved Hide resolved
packages/types/src/cart/mutations.ts Show resolved Hide resolved
packages/types/src/cart/mutations.ts Outdated Show resolved Hide resolved
packages/types/src/cart/service.ts Outdated Show resolved Hide resolved
packages/types/src/cart/service.ts Show resolved Hide resolved
@adrien2p
Copy link
Member

adrien2p commented Jan 9, 2024

The entire pipeline is red, can you get it to green? 😄

@olivermrbl olivermrbl force-pushed the feat/cart-module-interface-types branch from c7e5e46 to d91ac3a Compare January 9, 2024 19:45
@olivermrbl
Copy link
Contributor Author

@adrien2p, let me know what you think about d91ac3a.

Only relevant, if we choose to proceed with mikro-orm v6

@adrien2p
Copy link
Member

@olivermrbl the changes about mikro sounds good to me, you can see more here. One question though, the migration guide deprecate older version of nodejs and typescript, what do you think? also, could it create issues to mix mikro orm versions in the utils package and the other packages?

@olivermrbl
Copy link
Contributor Author

could it create issues to mix mikro orm versions in the utils package and the other packages

We should upgrade all Mikro dependencies to v6. I just pushed this to the cart first to demonstrate the changes.

That said, I was maybe too hasty on this as it requires more changes than initially expected and a bit more thought. Therefore, I will revert the most recent commit to proceed with the Cart Module PRs.

We can then address the v6 upgrade in a separate, dedicated PR.

Sound OK to you?

@olivermrbl olivermrbl requested a review from adrien2p January 10, 2024 09:27
@olivermrbl olivermrbl force-pushed the feat/cart-module-interface-types branch from dbb5551 to 91314cf Compare January 10, 2024 11:58
riqwan
riqwan approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question, but lgtm!

@olivermrbl olivermrbl merged commit ef50249 into develop Jan 10, 2024
25 checks passed
@olivermrbl olivermrbl deleted the feat/cart-module-interface-types branch January 10, 2024 12:28
pKorsholm pushed a commit that referenced this pull request Jan 10, 2024
@olivermrbl @pKorsholm
feat(cart): Public-facing DTOs + (partial) module interface (#6000)
ec202ef
kodiakhq bot pushed a commit that referenced this pull request Jan 12, 2024
@olivermrbl
feat(cart): Partial module service implementation (#6012)
192bc33 
Awaiting #6000 #6008  

**What**
- CRUD for Address in Cart Module service
- Tests for CRUD Carts + Address

**Not**
- Line items, shipping methods, tax lines, adjustment lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riqwan riqwan riqwan approved these changes

@adrien2p adrien2p Awaiting requested review from adrien2p

@fPolic fPolic Awaiting requested review from fPolic

@pKorsholm pKorsholm Awaiting requested review from pKorsholm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olivermrbl @adrien2p @riqwan