Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(medusa, orchestration, utils, workflows-sdk): add transaction options support and cleanup #6020

Merged
merged 5 commits into from
Jan 8, 2024

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Jan 8, 2024

What

  • Fix the config loading for the module
    • Set debug to false by default
    • include the connection
    • fix client url retrieval

Overall, the above changes fixes the migrations that are run from the module when running the cli migration command. The client url wasn't properly loaded.

  • Add support for the transaction options
  • Include the inject shared context decorator which was stuck in the search pr

Copy link

changeset-bot bot commented Jan 8, 2024

🦋 Changeset detected

Latest commit: e24094b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@medusajs/medusa Patch
@medusajs/orchestration Patch
@medusajs/utils Patch
@medusajs/workflows-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 0:44am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2024 0:44am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2024 0:44am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2024 0:44am

@adrien2p adrien2p marked this pull request as ready for review January 8, 2024 10:25
@adrien2p adrien2p requested a review from a team as a code owner January 8, 2024 10:25
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlos-r-l-rodrigues carlos-r-l-rodrigues merged commit fbee006 into develop Jan 8, 2024
16 checks passed
This was referenced Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants