Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eslint configurations in the root #6049

Merged
merged 2 commits into from
Jan 13, 2024
Merged

fix: eslint configurations in the root #6049

merged 2 commits into from
Jan 13, 2024

Conversation

shahednasser
Copy link
Member

When running yarn lint in the root of the monorepo, we get the following error:

Oops! Something went wrong! :(

ESLint: 8.44.0

Error: ESLint configuration in .eslintrc.js is invalid:
	- Unexpected top-level property "overrides[4].ignorePatterns".

Rmoving the ignorePatterns in configurations for packages/admin-next/dashboard/**/* and instead adding the path packages/admin-next/dashboard/**/dist fixes the issue.

When running `yarn lint` in the root of the monorepo, we get the following error:

```bash
Oops! Something went wrong! :(

ESLint: 8.44.0

Error: ESLint configuration in .eslintrc.js is invalid:
	- Unexpected top-level property "overrides[4].ignorePatterns".
```

Rmoving the `ignorePatterns` in configurations for `packages/admin-next/dashboard/**/*` and instead adding the path `packages/admin-next/dashboard/**/dist` fixes the issue.
Copy link

changeset-bot bot commented Jan 10, 2024

⚠️ No Changeset found

Latest commit: ba20927

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2024 1:10pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2024 1:10pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2024 1:10pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2024 1:10pm

@kodiakhq kodiakhq bot merged commit 33ff241 into develop Jan 13, 2024
16 checks passed
@kodiakhq kodiakhq bot deleted the fix/eslint-config branch January 13, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants