-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): add customers domain #6093
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
todo: I can't exit the "double cancel conf." flow: CleanShot.2024-01-16.at.10.14.31.mp4 |
todo: I can't update customers with a registered account, because we pass the email: CleanShot.2024-01-16.at.10.16.19.mp4 |
I agree it's an essential feature. But as long as we don't have a sophisticated RBAC, an email flow, or something similar, I would argue it could cause more harm than good, as anyone with access to admin can update other customers' passwords. The fact that you need to do it in the DB right now is actually perhaps a good layer of security until something else is in place. And since this is not supported in our admin right now, we won't be robbing existing users' of a feature. Update: fwiw, I checked with Shopify and Magento, and they both eliminated the feature in their recent versions in favor of an email flow |
What
Note
Some things are in-complete and will be followed up in future PRs:
CLOSES CORE-1647