Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cart): Shipping method adjustments #6119

Merged
merged 15 commits into from
Jan 22, 2024
Merged

feat(cart): Shipping method adjustments #6119

merged 15 commits into from
Jan 22, 2024

Conversation

olivermrbl
Copy link
Contributor

awaiting #6101

What

Add shipping method adjustments

addShippingMethodAdjustments(data: CreateShippingMethodAdjustmentDTO[])
addShippingMethodAdjustments(data: CreateShippingMethodAdjustmentDTO)
addShippingMethodAdjustments(cartId: string, data: CreateShippingMethodAdjustmentDTO[], sharedContext?: Context)

Set shipping method adjustments

setShippingMethodAdjustments(cartId: string, data: (CreateShippingMethodAdjustmentDTO  | UpdateShippingMethodAdjustmentDTO)[], sharedContext?: Context)

Remove shipping method adjustments

removeShippingMethodAdjustments(adjustmentIds: string[], sharedContext?: Context)
removeShippingMethodAdjustments(adjustmentIds: string, sharedContext?: Context)
removeShippingMethodAdjustments(selector: Partial<ShippingMethodAdjustmentLineDTO>,sharedContext?: Context)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 17, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 3c0338c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 9:21am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jan 22, 2024 9:21am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 9:21am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 9:21am

@olivermrbl olivermrbl force-pushed the feat/cm-shipping-adjustments branch 2 times, most recently from f46c133 to c134882 Compare January 18, 2024 12:43
@olivermrbl olivermrbl force-pushed the feat/cm-shipping-adjustments branch from c134882 to e3ac3cb Compare January 18, 2024 12:44
@olivermrbl olivermrbl force-pushed the feat/cm-shipping-adjustments branch from 175a350 to 5f4803d Compare January 19, 2024 10:54
@olivermrbl olivermrbl marked this pull request as ready for review January 19, 2024 11:25
@olivermrbl olivermrbl requested review from a team as code owners January 19, 2024 11:25
riqwan
riqwan approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments, but lgtm!

packages/cart/integration-tests/__tests__/services/cart-module/index.spec.ts Outdated Show resolved Hide resolved
packages/cart/src/models/shipping-method-adjustment.ts Show resolved Hide resolved
packages/cart/src/models/shipping-method-adjustment.ts Outdated Show resolved Hide resolved
packages/cart/src/services/cart-module.ts Outdated Show resolved Hide resolved
packages/cart/src/services/cart-module.ts Outdated Show resolved Hide resolved
packages/cart/src/services/cart-module.ts Outdated Show resolved Hide resolved
packages/types/src/cart/service.ts Outdated Show resolved Hide resolved
packages/types/src/cart/service.ts Outdated Show resolved Hide resolved
@olivermrbl olivermrbl requested a review from riqwan January 22, 2024 09:19
@olivermrbl olivermrbl merged commit fd78f5e into develop Jan 22, 2024
16 checks passed
@olivermrbl olivermrbl deleted the feat/cm-shipping-adjustments branch January 22, 2024 10:29
This was referenced Jan 22, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riqwan riqwan Awaiting requested review from riqwan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olivermrbl @riqwan