Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cart): Item tax lines + shipping method tax lines #6136

Merged
merged 16 commits into from
Jan 24, 2024
Merged

feat(cart): Item tax lines + shipping method tax lines #6136

merged 16 commits into from
Jan 24, 2024

Conversation

olivermrbl
Copy link
Contributor

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7afe902

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 11:30am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jan 24, 2024 11:30am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2024 11:30am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2024 11:30am

@olivermrbl olivermrbl marked this pull request as ready for review January 22, 2024 11:51
@olivermrbl olivermrbl requested review from a team as code owners January 22, 2024 11:51
@olivermrbl olivermrbl changed the title [wip] feat(cart): Item tax lines + shipping method tax lines feat(cart): Item tax lines + shipping method tax lines Jan 22, 2024
@olivermrbl olivermrbl mentioned this pull request Jan 22, 2024
Merged
srindom
srindom reviewed Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only blocking thing is the typo in packages/types/src/cart/common.ts

packages/cart/src/models/line-item-tax-line.ts Outdated Show resolved Hide resolved
packages/cart/src/models/shipping-method-tax-line.ts Outdated Show resolved Hide resolved
packages/cart/src/services/line-item-tax-line.ts Outdated Show resolved Hide resolved
packages/cart/src/types/repositories.ts Outdated Show resolved Hide resolved
packages/types/src/cart/common.ts Outdated Show resolved Hide resolved
packages/cart/src/services/cart-module.ts Outdated Show resolved Hide resolved
packages/cart/src/services/cart-module.ts Outdated Show resolved Hide resolved
packages/cart/src/services/cart-module.ts
: [taxLineIdsOrSelector]
}

await this.lineItemTaxLineService_.delete(ids, sharedContext)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: ideally the delete on the factory should support selectors so we can just pass straight through and avoid the list cc: @adrien2p

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it is plan 👍

packages/cart/src/services/cart-module.ts Show resolved Hide resolved
packages/cart/integration-tests/__tests__/services/cart-module/index.spec.ts Show resolved Hide resolved
@olivermrbl olivermrbl force-pushed the feat/cm-item-tax-lines branch 2 times, most recently from e8be220 to 5cac743 Compare January 23, 2024 19:57
@olivermrbl olivermrbl force-pushed the feat/cm-item-tax-lines branch from 5cac743 to b323a12 Compare January 23, 2024 20:00
@olivermrbl olivermrbl requested a review from srindom January 23, 2024 20:01
srindom
srindom approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olivermrbl
Copy link
Contributor Author

Need to fix a type issue, I see

adrien2p
adrien2p reviewed Jan 24, 2024
View reviewed changes
packages/cart/src/services/cart-module.ts Show resolved Hide resolved
packages/cart/src/services/cart-module.ts Show resolved Hide resolved
packages/cart/src/services/cart-module.ts
: [taxLineIdsOrSelector]
}

await this.lineItemTaxLineService_.delete(ids, sharedContext)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it is plan 👍

packages/cart/src/services/cart-module.ts Show resolved Hide resolved
packages/cart/src/services/cart-module.ts Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 2b35700 into develop Jan 24, 2024
16 checks passed
@kodiakhq kodiakhq bot deleted the feat/cm-item-tax-lines branch January 24, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien2p adrien2p adrien2p left review comments

@srindom srindom srindom approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olivermrbl @srindom @adrien2p