Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(authentication, types): split authenticate method into two #6184

Merged
merged 60 commits into from
Jan 26, 2024
Merged

feat(authentication, types): split authenticate method into two #6184

merged 60 commits into from
Jan 26, 2024

Conversation

pKorsholm
Copy link
Contributor

@pKorsholm pKorsholm commented Jan 23, 2024 •
edited
Loading

What

  • split authtenticate method into
    • initializeAuthentication
    • authenticateCallback

Why

  • OAuth2 handlers require initialization of a request to a third party and handling a callback when the authentication is validated. This pr splits the two actions to ensure each method is only responsible for handling a specific part of the authentication flow

pKorsholm and others added 30 commits January 22, 2024 17:53
@pKorsholm
init
72f0e14
@pKorsholm
fetch providers using updated string
f8b7089
@pKorsholm
update loaders
5adca1c
@pKorsholm
add more tests
276f3eb
@pKorsholm
add authenticationresponse type
01578e7
@pKorsholm
update types for authentication method
757039d
@pKorsholm
add entity_id and update provider
2adb779
@pKorsholm
update pr with return type
6db3a46
@pKorsholm
create loaders onApplicationStart
0bf5230
@pKorsholm
cleanup provider class
8b2f0f1
@pKorsholm
run application start hook before each
eda5647
@pKorsholm
fix pr feedback
3e99dff
@pKorsholm
create private onApplicationStart method
5bf05cc
@pKorsholm
Merge branch 'develop' into feat/authentication-provider-username-pas…
f5c4c1f 
…sword
@pKorsholm
assign repository
306c972
@pKorsholm
init
80e7012
@pKorsholm
add entity_id and update provider
e7bd8cd
@pKorsholm
initial implementation
465cfa7
@pKorsholm
update lockfile
4bb7889
@pKorsholm
fix conflicts
1ffff8a
@pKorsholm
add config variables
0b1f784
@pKorsholm
update types
620d93d
@pKorsholm
refactor google provider
9e916dc
@pKorsholm
re-order methods
b4bf540
@pKorsholm
fix pr feedback p. 1
4aa760f
@pKorsholm
add initial type and update callback authorization
63a85c9
@pKorsholm
add google provider to integration test
c874504
@pKorsholm
fix feedback
9a17515
@pKorsholm
initial implementation (#6171)
020b845 
* initial implementation

* remove oauth lib
@pKorsholm
move abstract authentication provider
dbac0ee
@pKorsholm pKorsholm marked this pull request as ready for review January 23, 2024 13:39
@pKorsholm pKorsholm requested review from a team as code owners January 23, 2024 13:39
@olivermrbl olivermrbl changed the title Feat(authentication, types): split authenticate method into two feat(authentication, types): split authenticate method into two Jan 23, 2024
@olivermrbl olivermrbl mentioned this pull request Jan 23, 2024
Merged
@olivermrbl olivermrbl changed the base branch from feat/google-authentication-provider to develop January 24, 2024 07:56
@olivermrbl
Copy link
Contributor

olivermrbl commented Jan 24, 2024 •
edited
Loading

Can I get you to rebase off of develop?

@pKorsholm pKorsholm force-pushed the feat/split-authentication-methods branch 2 times, most recently from fab554f to 03475a4 Compare January 25, 2024 04:13
@pKorsholm pKorsholm merged commit 638b47f into develop Jan 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@adrien2p adrien2p Awaiting requested review from adrien2p

@olivermrbl olivermrbl Awaiting requested review from olivermrbl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pKorsholm @olivermrbl @adrien2p @carlos-r-l-rodrigues