Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(medusa, stock-location, types): Add q and order params to list-stock-locations #6197

Merged
merged 9 commits into from
Jan 29, 2024

Conversation

pKorsholm
Copy link
Contributor

What

  • add q and order params to list-stock-location endpoint

closes #6189

@pKorsholm pKorsholm requested review from a team as code owners January 24, 2024 03:47
Copy link

changeset-bot bot commented Jan 24, 2024

🦋 Changeset detected

Latest commit: e77cc57

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@medusajs/stock-location Patch
@medusajs/medusa Patch
@medusajs/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 8:53am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jan 29, 2024 8:53am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 8:53am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 8:53am

Copy link
Contributor

@kasperkristensen kasperkristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Phil! Looks great just added two small comments ✌️

packages/stock-location/src/utils/build-query.ts Outdated Show resolved Hide resolved
packages/types/src/stock-location/common.ts Outdated Show resolved Hide resolved
@olivermrbl
Copy link
Contributor

olivermrbl commented Jan 29, 2024

@pKorsholm can I get you to fix the integration tests, so we can merge?

@kodiakhq kodiakhq bot merged commit d1c18a3 into develop Jan 29, 2024
17 checks passed
@kodiakhq kodiakhq bot deleted the feat/add-q-and-order-to-stock-location branch January 29, 2024 09:14
This was referenced Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(medusa): GET /admin/stock-locations does not have a q and order param
3 participants