Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(medusa-test-utils, authentication, customer, cart, payment, pricing, product, promotion): Add initModule util #6200

Merged
merged 15 commits into from
Jan 25, 2024
Merged

Feat(medusa-test-utils, authentication, customer, cart, payment, pricing, product, promotion): Add initModule util #6200

merged 15 commits into from
Jan 25, 2024

Conversation

pKorsholm
Copy link
Contributor

@pKorsholm pKorsholm commented Jan 24, 2024 •
edited
Loading

What

  • Add initModule util to load modules in integration tests using medusaApp

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 801e2da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2024 1:20am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jan 25, 2024 1:20am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 25, 2024 1:20am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 25, 2024 1:20am

adrien2p
adrien2p reviewed Jan 24, 2024
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice, I would just return everything from the medusa app in case you need to access the query or run migration etc.

cc @carlos-r-l-rodrigues

@pKorsholm pKorsholm marked this pull request as ready for review January 24, 2024 10:15
@pKorsholm pKorsholm requested review from a team as code owners January 24, 2024 10:15
adrien2p
adrien2p approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥 just need to CI to pass

carlos-r-l-rodrigues
carlos-r-l-rodrigues approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. Thank you

packages/customer/integration-tests/utils/get-init-module-config.ts Outdated Show resolved Hide resolved
packages/authentication/integration-tests/utils/get-init-module-config.ts Outdated Show resolved Hide resolved
@pKorsholm pKorsholm merged commit efd9204 into develop Jan 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@adrien2p adrien2p adrien2p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pKorsholm @adrien2p @carlos-r-l-rodrigues