-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(customer): add migration file #6205
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
@carlos-r-l-rodrigues redid the file please take another look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It is just missing the create table customer if not exists.
Sorry, I just spotted a couple of other details. All the tables involved in public methods exposed by the module will have to be "soft deletable", that way the workflows can restore it if needed. |
bf08d01
to
89ec9d0
Compare
@carlos-r-l-rodrigues - Is there something that needs to be done from a MikroORM perspective for this to work properly right now I just added it in the raw SQL? |
Seems like it's only supported through custom expressions mikro-orm/mikro-orm#2837 So this should be sufficient right? |
Correct. if we want to auto generate that. |
No description provided.