Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): Users domain #6212

Merged
merged 7 commits into from
Jan 30, 2024
Merged

feat(dashboard): Users domain #6212

merged 7 commits into from
Jan 30, 2024

Conversation

kasperkristensen
Copy link
Contributor

What

  • Adds users domain with list, detail, edit, and invite views

@kasperkristensen kasperkristensen requested review from a team as code owners January 24, 2024 18:15
Copy link

changeset-bot bot commented Jan 24, 2024

⚠️ No Changeset found

Latest commit: 9402ab4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 1 resolved Jan 30, 2024 4:19pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) 💬 Add feedback Jan 30, 2024 4:19pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 4:19pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 4:19pm

@srindom
Copy link
Collaborator

srindom commented Jan 26, 2024

This looks incorrect:
CleanShot 2024-01-26 at 1  54 17

When clicking edit from the table view, I think the experience would be better if the edit menu folds out directly over the table instead of navigating you to the user details page and then opening the edit side bar.
https://github.com/medusajs/medusa/assets/7554214/ce1b8a16-1043-4e68-b4eb-38d05abea4f3

@olivermrbl
Copy link
Contributor

Aside from @srindom's comments, LGTM!

@kasperkristensen
Copy link
Contributor Author

@srindom It seems like the staging server hasn't been redeployed with the latest updates to the /admin/users endpoint so it's not returning count, which is why it's showing 0 of 0. If you run it locally with the latest version of Medusa it should be good

Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srindom It seems like the staging server hasn't been redeployed with the latest updates to the /admin/users endpoint so it's not returning count, which is why it's showing 0 of 0. If you run it locally with the latest version of Medusa it should be good

Got it! LGTM

@olivermrbl olivermrbl merged commit 1100c21 into develop Jan 30, 2024
17 checks passed
@olivermrbl olivermrbl deleted the feat/3.0-users branch January 30, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants