Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core-flows): reorganize folder structure for promotion workflows #6243

Merged
merged 5 commits into from
Jan 29, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Jan 28, 2024

workflows folder structure:

- src/
  - promotion/
    - workflows/
      - create-promotion.ts
    - steps/
      - prepare-create-promotion-data.ts

RESOLVES CORE-1688

Copy link

changeset-bot bot commented Jan 28, 2024

⚠️ No Changeset found

Latest commit: 4c7bf1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 2:15pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jan 29, 2024 2:15pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 2:15pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 2:15pm

Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: does it make sense to include these for v2 work since it's not user facing yet? Or maybe we should at least indicate that this is for v2 so the changelog will reflect it. cc: @olivermrbl

Copy link
Contributor

@olivermrbl olivermrbl Jan 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can omit the changeset.

However, since this package can contain both v1 and v2 updates, we can't guarantee these changes won't be part of a future release anyway.

Also, not sure how noting the FF would work with PRs that touch several packages and with both v1 and v2 changes. Perhaps, breaking up the changesets could be an approach for having a sensible changelog for this case.

@kodiakhq kodiakhq bot merged commit 10c67ec into develop Jan 29, 2024
17 checks passed
@kodiakhq kodiakhq bot deleted the chore/folder-reorg branch January 29, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants