-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(core-flows): reorganize folder structure for promotion workflows #6243
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.changeset/fluffy-balloons-eat.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: does it make sense to include these for v2 work since it's not user facing yet? Or maybe we should at least indicate that this is for v2 so the changelog will reflect it. cc: @olivermrbl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can omit the changeset.
However, since this package can contain both v1 and v2 updates, we can't guarantee these changes won't be part of a future release anyway.
Also, not sure how noting the FF would work with PRs that touch several packages and with both v1 and v2 changes. Perhaps, breaking up the changesets could be an approach for having a sensible changelog for this case.
workflows folder structure:
RESOLVES CORE-1688