Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cart): Clean up data models #6256

Merged
merged 3 commits into from
Jan 29, 2024
Merged

chore(cart): Clean up data models #6256

merged 3 commits into from
Jan 29, 2024

Conversation

olivermrbl
Copy link
Contributor

Clean up data models in Cart Module according to latest established conventions

@olivermrbl olivermrbl requested review from a team as code owners January 29, 2024 12:29
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d567a7f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 6:10pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jan 29, 2024 6:10pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 6:10pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 6:10pm

riqwan
riqwan approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

packages/cart/src/models/address.ts Outdated Show resolved Hide resolved
packages/cart/src/models/shipping-method.ts Show resolved Hide resolved
@olivermrbl @riqwan
chore: Update packages/cart/src/models/address.ts
54d24ec 
Co-authored-by: Riqwan Thamir <rmthamir@gmail.com>
@kodiakhq kodiakhq bot merged commit 1c27f7c into develop Jan 29, 2024
17 checks passed
@kodiakhq kodiakhq bot deleted the chore/clean-up-models branch January 29, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riqwan riqwan riqwan approved these changes

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olivermrbl @riqwan @srindom