Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth): add authentication endpoints #6265
feat(auth): add authentication endpoints #6265
Changes from 75 commits
dacdb27
cd38e4c
d3fd771
512f5df
908e5e6
4bd6491
9869c71
36d51ef
7553ea0
ecd2250
333a268
036e577
9d49a5d
99c8e2d
94cf842
e6baee6
76ca08e
0418435
fe2c5c3
d8e5415
9c6a487
5cc7742
44dbffd
d33f05d
e4b0808
560162a
2742d5d
b92d8a0
e6a4d59
58144bb
5e04717
21d165d
a51c569
6b9c832
96e12e6
6856205
9b05eda
f4b02a0
b58d304
48f41e2
099f1e0
3e0e16d
6b91e87
201a690
6b494a6
a6c69e2
1e29439
e7e5fde
7d90532
753e59c
671404f
94cc17f
a8132f4
4f5753d
dc6e669
68cd24c
decb5db
2afcae8
1fda3f2
3e87fea
4d61cdd
06f2adc
91d46ce
42b3a6d
ee398a6
d43cdfb
eeffa8e
e5715b1
36a6d83
fe6bb3d
d0d64ea
bf2ba61
bab06a2
c837d7a
1ecebf4
be95dce
ec43f6f
5acba3b
0937f31
237a802
2f9c25b
8c41abb
63adf0b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if there is a location (the redirect could be configured) then we don't check any success or failure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we could validate to ensure that
success
is required if you think that's appropriate? 😄 just figured that in case of a redirect you would want that no matter whatThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in general you have a success redirect and a failure redirect that eventually could have custom query parameters, let see that later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: shouldn't the client be the one doing the redirect?