Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cart): POST /store/carts #6273

Merged
merged 16 commits into from
Feb 5, 2024
Merged

feat(cart): POST /store/carts #6273

merged 16 commits into from
Feb 5, 2024

Conversation

olivermrbl
Copy link
Contributor

@olivermrbl olivermrbl commented Jan 30, 2024 •
edited
Loading

Depends on #6262

@olivermrbl olivermrbl requested review from a team as code owners January 30, 2024 09:39
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ac2a275

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2024 2:56pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 5, 2024 2:56pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 2:56pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 2:56pm

@olivermrbl
Copy link
Contributor Author

olivermrbl commented Jan 30, 2024 •
edited
Loading

Would like us to consider changing to zod for API body validation: https://github.com/medusajs/medusa/compare/feat/cm-create-cart-zod?expand=1

More specifically, this file demonstrates how the schemas will look like with zod.

@olivermrbl olivermrbl mentioned this pull request Jan 30, 2024
Merged
srindom
srindom approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - w. a small nit.

+1 from my side on zod - the class-validator stuff is awfully hard to dance with.

packages/medusa/src/types/routing.ts Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit ede221d into develop Feb 5, 2024
17 checks passed
@kodiakhq kodiakhq bot deleted the feat/cm-create-cart branch February 5, 2024 15:15
kodiakhq bot pushed a commit that referenced this pull request Feb 14, 2024
@olivermrbl
feat(cart): POST /store/carts/:id (#6274)
1ed5f91 
Depends on:
- #6262 
- #6273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srindom srindom srindom approved these changes

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olivermrbl @srindom