Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(customer): store addresses #6283

Merged
merged 8 commits into from
Feb 1, 2024
Merged

feat(customer): store addresses #6283

merged 8 commits into from
Feb 1, 2024

Conversation

srindom
Copy link
Collaborator

@srindom srindom commented Jan 31, 2024 •
edited
Loading

  • GET /customers/me/addresses
  • POST /customers/me/addresses
  • GET /customers/me/addresses/:address_id
  • POST /customers/me/addresses/:address_id
  • DELETE /customers/me/addresses/:address_id

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 68c88d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 9:51am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 1, 2024 9:51am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 9:51am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 9:51am

@srindom srindom marked this pull request as ready for review January 31, 2024 15:17
@srindom srindom requested review from a team as code owners January 31, 2024 15:17
@srindom srindom changed the title Feat/customer store addresses feat(customer): store addresses Jan 31, 2024
olivermrbl
olivermrbl approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

suggestion(non-blocking): Use remoteQuery for list and get

packages/medusa/src/api-v2/store/customers/validators.ts
@@ -27,3 +38,207 @@ export class StorePostCustomersReq {
@IsOptional()
metadata?: Record<string, unknown>
}

export class StorePostCustomersMeAddressesReq {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥲

@srindom
Copy link
Collaborator Author

srindom commented Feb 1, 2024

suggestion(non-blocking): Use remoteQuery for list and get
Will do separately!

@kodiakhq kodiakhq bot merged commit a28822e into develop Feb 1, 2024
17 checks passed
@kodiakhq kodiakhq bot deleted the feat/customer-store-addresses branch February 1, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srindom @olivermrbl