-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(modules-sdk): Module provider plugin loader #6286
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
b2e7a71
to
a76ab8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
just a small comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💪 small suggestions and todo
packages/modules-sdk/src/loaders/__tests__/module-provider-loader.ts
Outdated
Show resolved
Hide resolved
@olivermrbl - is this ready to merge? |
Yes, I will work on the changes for provider plugins in a follow-up PR. I.e. the changes needed in the Payment Module to load multiple provider installations like so: /**
* Example: Payment provider installation
* {
* resolve: "@medusajs/payment-stripe",
* options: {
* providers: {
* dkk: { ...credentials }
* usd: { ...credentials }
* }
* }
* }
*
* The installation above will install the Stripe payment provider plugin.
* The plugin is installed with two sets of credentials, one for a DKK Stripe account and one for a USD Stripe account.
*/ This will not touch the general module provider loading mechanism but instead be specific to modules. This is where the |
What
Allow plugins to be installed in a module: