Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(customer): manage default address selection #6295

Merged
merged 4 commits into from
Feb 1, 2024
Merged

feat(customer): manage default address selection #6295

merged 4 commits into from
Feb 1, 2024

Conversation

srindom
Copy link
Collaborator

@srindom srindom commented Feb 1, 2024 •
edited
Loading

What

  • Catches unique constraints on customer_id, is_default_billing/is_default_shipping and reformats
  • Adds an step to create and update of addresses that unsets the previous default shipping/billing address if necessary.
    • This creates a behavior in the API where you can always set an address to be default and it will automatically unset the previous one for you.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 94bcab0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 10:33am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 1, 2024 10:33am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 10:33am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 10:33am

@srindom srindom marked this pull request as ready for review February 1, 2024 10:31
@srindom srindom requested review from a team as code owners February 1, 2024 10:31
olivermrbl
olivermrbl approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like the unsetting pattern

packages/customer/src/services/customer-module.ts
@@ -775,4 +782,30 @@ export default class CustomerModuleService implements ICustomerModuleService {
)
: void 0
}

private async flush(context: Context) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: This could live as a MikroORM util no? It only depends on the context

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it could - let's leave it here until we meet the pattern in other places

@kodiakhq kodiakhq bot merged commit a2bf675 into develop Feb 1, 2024
17 checks passed
@kodiakhq kodiakhq bot deleted the feat/cusmod-validation branch February 1, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srindom @olivermrbl