feat(dashboard): DataTable component #6297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6c51535 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
kasperkristensen
commented
Feb 1, 2024
Comment on lines
50
to
59
| /** | ||
| * TODO | ||
| * | ||
| * Add a sticky header to the table that shows the column name when scrolling through the table vertically. | ||
| * | ||
| * This is a bit tricky as we can't support horizontal scrolling and sticky headers at the same time, natively | ||
| * with CSS. We need to implement a custom solution for this. One solution is to render a duplicate table header | ||
| * using a DIV that, but it will require rerendeing the duplicate header every time the window is resized, to keep | ||
| * the columns aligned. | ||
| */ |
There was a problem hiding this comment.
comment: This will be implemented in a follow up PR, most likely after the first iteration of Admin 3.0.
kasperkristensen
commented
Feb 1, 2024
Comment on lines
+9
to
+11
| /** | ||
| * TODO: Enable `order` query param when staging is updated | ||
| */ |
There was a problem hiding this comment.
comment: Currently the Order menu does nothing for the Order tables. Will enable it once staging has been updated, as it would currently crash the page.
olivermrbl
approved these changes
Feb 2, 2024
|
This is really pretty! We should re-add the customer information in the order overview though |
This was referenced Feb 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
prefixcan be passed to the component to differentiate the params for each table.Note