You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the access modifier for the axiosClient within the request module for medusa-js.
Why - why are these changes relevant
Our project currently has an extended medusaClient which has an overwritten axiosClient under the hood. This axiosClient has some interceptors that help us manage our responses and errors in a unified way and it works great for all of our custom endpoints.
The issue is with calls that are made via custom hooks via medusa-js. These calls are made by a different medusaClient and there's no way for us to provide our custom one to the MedusaProvider so that ours is used throughout the app.
How - how have the changes been implemented
Added a field to allow for passing in a medusaClient of choice.
Testing - how has the changes been tested or how can the reviewer test the feature
Not sure how one goes about firing up any service within the monorepo to test this properly, but TypeScript seems happy with the update.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
thanks Oli - looks good. Are you planning to add the withCredentials settings in the medusaClient? Now that the Bearer auth is live it would be great to have the possibility to set that to false.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
erikengervall
force-pushed
the
feat/add-medusa-as-argument-to-medusa-provider-
branch
from
What - what changes are in this PR
Adds an optional
medusaClienttoMedusaProviderUpdates the access modifier for the
axiosClientwithin the request module formedusa-js.Why - why are these changes relevant
Our project currently has an extended
medusaClientwhich has an overwrittenaxiosClientunder the hood. ThisaxiosClienthas some interceptors that help us manage our responses and errors in a unified way and it works great for all of our custom endpoints.The issue is with calls that are made via custom hooks via
medusa-js. These calls are made by a differentmedusaClientand there's no way for us to provide our custom one to theMedusaProviderso that ours is used throughout the app.How - how have the changes been implemented
Added a field to allow for passing in a
medusaClientof choice.Testing - how has the changes been tested or how can the reviewer test the feature
Not sure how one goes about firing up any service within the monorepo to test this properly, but TypeScript seems happy with the update.