feat(): added percentage calculations for all cases #6300
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
| const totalItemValue = method.unit_price * quantityMultiplier | ||
| let promotionValue = parseFloat(applicationMethod!.value!) | ||
| const applicableTotal = totalItemValue - appliedPromoValue | ||
|
|
||
| if (applicationMethod?.type === ApplicationMethodType.PERCENTAGE) { | ||
| promotionValue = (promotionValue / 100) * applicableTotal | ||
| } | ||
|
|
There was a problem hiding this comment.
thought: would it make sense to move all this responsibility outside of the promotion module - instead the promotion module would expect subtotal fields on the items it gets passed?
There was a problem hiding this comment.
todo: use method.subtotal / method.quantity instead of method.unit_price.
what: