fix(admin-ui) Refactor use-copy-promotion to map product IDs
#6306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5486ca0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@erikengervall is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
|
@erikengervall, thanks for the contribution. I realise you also cannot copy discounts that have other conditions than products. We will attend to this :) |
olivermrbl
approved these changes
Feb 2, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
This was referenced Feb 2, 2024
Merged
This was referenced Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What - what changes are in this PR
Fixes invalid payload for duplicate coupon button.
Why - why are these changes relevant
It currently throws an error due to invalid parameters.
How - how have the changes been implemented
Sending an array of product ids instead of an array of products.
Testing - how has the changes been tested or how can the reviewer test the feature
Can't upload files larger than 10MB, so here's a video of my evidence https://www.youtube.com/watch?v=yCaxl0OM0wY