Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(region): Region create, delete, update admin endpoints #6332

Merged
merged 15 commits into from
Feb 20, 2024
Merged

feat(region): Region create, delete, update admin endpoints #6332

merged 15 commits into from
Feb 20, 2024

Conversation

olivermrbl
Copy link
Contributor

@olivermrbl olivermrbl commented Feb 6, 2024 •
edited
Loading

What
Add POST /admin/regions
Add POST /admin/regions/:id
Add DELETE /admin/regions/:id

All are added for v2 using API Routes and workflows.

In follow-up PRs, I will add support for passing countries in update and create.

Update: First follow-up PR is #6372

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 185d5e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 9:56am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 20, 2024 9:56am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2024 9:56am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2024 9:56am

@olivermrbl olivermrbl marked this pull request as ready for review February 11, 2024 20:42
@olivermrbl olivermrbl requested review from a team as code owners February 11, 2024 20:42
@olivermrbl olivermrbl requested a review from adrien2p February 12, 2024 19:47
sradevski
sradevski reviewed Feb 16, 2024
View reviewed changes
packages/types/src/region/mutations.ts Show resolved Hide resolved
packages/medusa/src/models/payment.ts Show resolved Hide resolved
packages/medusa/src/api-v2/admin/regions/validators.ts Show resolved Hide resolved
packages/medusa/src/api-v2/admin/regions/validators.ts Show resolved Hide resolved
packages/medusa/src/api-v2/admin/regions/route.ts Show resolved Hide resolved
packages/medusa/src/api-v2/admin/regions/[id]/route.ts Show resolved Hide resolved
packages/core-flows/src/region/workflows/update-regions.ts Show resolved Hide resolved
packages/core-flows/src/region/steps/update-regions.ts Show resolved Hide resolved
integration-tests/plugins/__tests__/regions/admin/create-region.spec.ts Outdated Show resolved Hide resolved
integration-tests/plugins/__tests__/regions/admin/update-region.spec.ts Outdated Show resolved Hide resolved
@olivermrbl olivermrbl requested review from adrien2p and a team February 16, 2024 13:34
@olivermrbl
Copy link
Contributor Author

olivermrbl commented Feb 19, 2024 •
edited
Loading

@medusajs/engineering, this one is longing for a review 😄

adrien2p
adrien2p approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few todo's left

integration-tests/plugins/__tests__/regions/admin/regions.spec.ts Show resolved Hide resolved
integration-tests/plugins/__tests__/regions/admin/regions.spec.ts Outdated Show resolved Hide resolved
integration-tests/plugins/__tests__/regions/admin/regions.spec.ts Show resolved Hide resolved
integration-tests/plugins/__tests__/regions/admin/regions.spec.ts Outdated Show resolved Hide resolved
packages/medusa/src/api-v2/admin/regions/query-config.ts
Comment on lines +23 to +25
defaultFields: defaultAdminRegionFields,
defaultRelations: defaultAdminRegionRelations,
allowedRelations: allowedAdminRegionRelations,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion(nit): we could just have defaultAdminRegionFields which already include the relations. In the route (for now but in the middleware would be better) we can use the util to get the select and relations from the fields. wdyt? Just in order to start the cleanup and not have to maintain two array etc and facilitate the migration later

@kodiakhq kodiakhq bot merged commit 691f68c into develop Feb 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srindom srindom srindom left review comments

@adrien2p adrien2p adrien2p approved these changes

@sradevski sradevski sradevski approved these changes

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olivermrbl @sradevski @srindom @adrien2p