Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(utils): psql unique index instead of constraint #6386

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

pKorsholm
Copy link
Contributor

What

  • always return an index expression, also for unique constraints

why

  • constraints can't be partial, meaning UNIQUE ... WHERE is not possible with constraints
  • constraints are indicies under the hood so it doesn't change the behavior of the system when we're not using constraint specific features but just using them for UNIQUE

@pKorsholm pKorsholm requested review from a team as code owners February 13, 2024 07:33
Copy link

changeset-bot bot commented Feb 13, 2024

🦋 Changeset detected

Latest commit: 855b54e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 7:45am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 13, 2024 7:45am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2024 7:45am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2024 7:45am

Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🎉

@kodiakhq kodiakhq bot merged commit a86c87f into develop Feb 13, 2024
17 checks passed
@kodiakhq kodiakhq bot deleted the feat/psql-unique-index-instead-of-constraint branch February 13, 2024 08:07
This was referenced Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants