Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fulfillment): implementation part 2 #6408

Merged
merged 42 commits into from
Feb 19, 2024

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Feb 15, 2024

What

Note

I can see this pr becoming huge, so I d like to get this partial one merged 👍

  • Fixes shared connection usage (mikro orm compare the instance to its own package and therefore was resulting in not trully reusing the provided connection leading to exhausting the connection pool as multiple connections was created and end up not being all destroyed properly under the hood, discovered in my integration tests)
  • Create shipping options method implementation
  • DTO's definition and service interface update
  • integration tests
  • Re work of the indexes with new util update
  • Test runner utils to remove a big chunk of the boilerplate of the packages integrations

FIXES CORE-1742

Copy link

changeset-bot bot commented Feb 15, 2024

🦋 Changeset detected

Latest commit: cd6ef57

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@medusajs/medusa Patch
medusa-test-utils Patch
@medusajs/product Patch
@medusajs/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview Feb 19, 2024 0:08am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 0:08am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2024 0:08am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2024 0:08am

@adrien2p adrien2p changed the title Afeat(fulfillment): implementation part 2 feat(fulfillment): implementation part 2 Feb 15, 2024
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work

@adrien2p
Copy link
Member Author

@olivermrbl @srindom can I slap an auto merge here if you are ok with the latest changes

@olivermrbl
Copy link
Contributor

Yes, sure!

@kodiakhq kodiakhq bot merged commit 1d91b74 into develop Feb 19, 2024
17 checks passed
@kodiakhq kodiakhq bot deleted the feat/fulfillment-implementation-2 branch February 19, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants