Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cart Customer link + create cart with customer #6426

Merged
merged 26 commits into from
Feb 19, 2024

Conversation

olivermrbl
Copy link
Contributor

@olivermrbl olivermrbl commented Feb 18, 2024

What

  • Add Cart Customer read-only link
  • Add findOrCreateCustomer step to CreateCartWorkflow. Three scenarios are covered:
    • Retrieve customer from passed ID
    • Retrieve customer from passed email
    • Create customer with passed email
  • Use signed-in customer id in POST /store/carts
  • Restructure tests

Tests

  • Cart Customer link queries
  • Create cart with existing customer
  • Create cart creates customer using email
  • Compensate: Should delete customer, if created from email
  • Compensate: Should not delete customer, if customer already existed

Note: Compensation flows are tested using the local workflow instead of the API, as we cannot modify the global workflow (yet)

@olivermrbl olivermrbl requested review from a team as code owners February 18, 2024 10:53
Copy link

changeset-bot bot commented Feb 18, 2024

⚠️ No Changeset found

Latest commit: dfefdcf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2024 2:32pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 18, 2024 2:32pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2024 2:32pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2024 2:32pm

Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olivermrbl olivermrbl merged commit 5db3ec0 into develop Feb 19, 2024
17 checks passed
@olivermrbl olivermrbl deleted the feat/create-cart-with-customer branch February 19, 2024 07:28
@olivermrbl olivermrbl restored the feat/create-cart-with-customer branch February 19, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants