Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(utils): Move generic utils from region module to utils #6466

Merged
merged 1 commit into from
Feb 22, 2024
Merged

chore(utils): Move generic utils from region module to utils #6466

merged 1 commit into from
Feb 22, 2024

Conversation

sradevski
Copy link
Member

Moves some generic utilities from the region module to the top-level utils package

@sradevski sradevski requested review from a team as code owners February 21, 2024 13:44
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d956d94

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 7:42am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 22, 2024 7:42am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 22, 2024 7:42am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 22, 2024 7:42am

@sradevski sradevski force-pushed the stevche/move-utils-from-region branch from 1deedc7 to 2296c7b Compare February 21, 2024 13:44
adrien2p
adrien2p approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, comments to review

@sradevski sradevski force-pushed the stevche/move-utils-from-region branch from 2296c7b to d956d94 Compare February 22, 2024 07:38
@kodiakhq kodiakhq bot merged commit add861d into develop Feb 22, 2024
17 checks passed
@kodiakhq kodiakhq bot deleted the stevche/move-utils-from-region branch February 22, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues left review comments

@adrien2p adrien2p adrien2p approved these changes

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sradevski @adrien2p @carlos-r-l-rodrigues