-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(workflows-sdk,core-flows,medusa,types): add workflow to update promotions to cart #6474
Conversation
🦋 Changeset detectedLatest commit: 2f848b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
packages/promotion/src/utils/compute-actions/shipping-methods.ts
Outdated
Show resolved
Hide resolved
|
||
const cart = await cartModuleService.create({ | ||
currency_code: "usd", | ||
items: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can create some fixtures that you can reuse, esp. in tests where the creation is just a matter of preparing for the actual test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Left a couple of comments and todos.
integration-tests/plugins/__tests__/cart/store/add-promotions-to-cart.spec.ts
Outdated
Show resolved
Hide resolved
packages/core-flows/src/definition/cart/steps/create-line-item-adjustments.ts
Outdated
Show resolved
Hide resolved
packages/core-flows/src/definition/cart/steps/create-shipping-method-adjustments.ts
Outdated
Show resolved
Hide resolved
packages/core-flows/src/definition/cart/steps/get-actions-to-compute-from-promotions.ts
Show resolved
Hide resolved
packages/medusa/src/api-v2/store/carts/[id]/promotions/route.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/api-v2/store/carts/[id]/promotions/route.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/api-v2/store/carts/[id]/promotions/route.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/api-v2/store/carts/[id]/promotions/route.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Oli Juhl <59018053+olivermrbl@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work!
what:
RESOLVES CORE-1768