Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflows-sdk,core-flows,medusa,types): add workflow to update promotions to cart #6474

Merged
merged 24 commits into from
Feb 26, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Feb 22, 2024

what:

  • adds API + workflow to add/remove promotions in a cart
  • minor fixes in promotions module
  • minor type fixes in cart module
  • typing fix in workflows-sdk (Thanks @adrien2p)
  • fix step result in workflows-sdk (Thanks @adrien2p)

RESOLVES CORE-1768

Copy link

changeset-bot bot commented Feb 22, 2024

🦋 Changeset detected

Latest commit: 2f848b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@medusajs/workflows-sdk Patch
@medusajs/core-flows Patch
@medusajs/medusa Patch
@medusajs/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 0:16am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 26, 2024 0:16am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2024 0:16am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2024 0:16am

@riqwan riqwan changed the title [WIP] feat(workflows-sdk,utils): added workflow to add promotion to cart feat(workflows-sdk,core-flows,medusa,types): add workflow to add promotions to cart Feb 23, 2024
@riqwan riqwan marked this pull request as ready for review February 23, 2024 08:27
@riqwan riqwan requested review from a team as code owners February 23, 2024 08:27
packages/workflows-sdk/src/utils/composer/create-step.ts Outdated Show resolved Hide resolved

const cart = await cartModuleService.create({
currency_code: "usd",
items: [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can create some fixtures that you can reuse, esp. in tests where the creation is just a matter of preparing for the actual test.

@riqwan riqwan changed the title feat(workflows-sdk,core-flows,medusa,types): add workflow to add promotions to cart feat(workflows-sdk,core-flows,medusa,types): add workflow to update promotions to cart Feb 23, 2024
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Left a couple of comments and todos.

riqwan and others added 2 commits February 25, 2024 19:48
Co-authored-by: Oli Juhl <59018053+olivermrbl@users.noreply.github.com>
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@kodiakhq kodiakhq bot merged commit ac86362 into develop Feb 26, 2024
17 checks passed
@kodiakhq kodiakhq bot deleted the feat/cart-promotions branch February 26, 2024 12:44
This was referenced Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants