Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api-key): Allow revoking in the future, and enforce the secret key #6484

Merged
merged 2 commits into from
Feb 27, 2024
Merged

feat(api-key): Allow revoking in the future, and enforce the secret key #6484

merged 2 commits into from
Feb 27, 2024

Conversation

sradevski
Copy link
Member

@sradevski sradevski commented Feb 23, 2024 •
edited
Loading

Since there is quite a bit of code here already, I'll do the middleware changes in a separate PR

@vercel Vercel
Copy link

vercel bot commented Feb 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2024 10:11am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 27, 2024 10:11am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2024 10:11am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2024 10:11am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e90dc43

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

adrien2p
adrien2p approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@sradevski sradevski force-pushed the feat/enforce-authentication-check-api-key branch from 6024193 to 2aa6051 Compare February 27, 2024 09:09
@sradevski sradevski marked this pull request as ready for review February 27, 2024 09:09
@sradevski sradevski requested review from a team as code owners February 27, 2024 09:09
@sradevski sradevski force-pushed the feat/enforce-authentication-check-api-key branch from 2aa6051 to 58ccfc6 Compare February 27, 2024 09:09
@sradevski sradevski requested a review from adrien2p February 27, 2024 09:10
@sradevski sradevski force-pushed the feat/enforce-authentication-check-api-key branch from 58ccfc6 to c8a5b9b Compare February 27, 2024 09:34
adrien2p
adrien2p approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few todo's and suggestions

packages/api-key/src/services/api-key-module-service.ts Outdated Show resolved Hide resolved
packages/api-key/src/services/api-key-module-service.ts Show resolved Hide resolved
packages/api-key/src/services/api-key-module-service.ts Outdated Show resolved Hide resolved
packages/api-key/src/services/api-key-module-service.ts Outdated Show resolved Hide resolved
packages/api-key/src/services/api-key-module-service.ts Outdated Show resolved Hide resolved
@sradevski sradevski force-pushed the feat/enforce-authentication-check-api-key branch from c8a5b9b to e90dc43 Compare February 27, 2024 10:07
@kodiakhq kodiakhq bot merged commit 690e8c2 into develop Feb 27, 2024
17 checks passed
@kodiakhq kodiakhq bot deleted the feat/enforce-authentication-check-api-key branch February 27, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien2p adrien2p adrien2p approved these changes

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sradevski @adrien2p