Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(utils): bignumber util considers nullable options when setting value #6499

Merged
merged 4 commits into from
Feb 26, 2024
Merged

fix(utils): bignumber util considers nullable options when setting value #6499

merged 4 commits into from
Feb 26, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Feb 25, 2024 •
edited
Loading

what:

  • when setting null for nullable columns, big number utils should not throw error
  • remove circular soft delete depenedencies for cart module
  • trims zeros on big number values

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 443fdf2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview Feb 26, 2024 11:05am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 11:05am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2024 11:05am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2024 11:05am

@riqwan riqwan marked this pull request as ready for review February 25, 2024 15:20
@riqwan riqwan requested review from a team as code owners February 25, 2024 15:20
@carlos-r-l-rodrigues
Copy link
Contributor

I am doing similar changes to it + some additional ones.
do you mind to bring that to this PR?

@riqwan
Copy link
Contributor Author

riqwan commented Feb 25, 2024

@carlos-r-l-rodrigues sounds good, I can do that once I'm back. 👍🏻

@riqwan riqwan force-pushed the fix/nullable-big-number branch from 1041667 to 9909455 Compare February 26, 2024 10:32
@riqwan
Copy link
Contributor Author

riqwan commented Feb 26, 2024

@carlos-r-l-rodrigues added them in here, let me know if i missed anything.

carlos-r-l-rodrigues
carlos-r-l-rodrigues approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit 8ea37d0 into develop Feb 26, 2024
17 checks passed
@kodiakhq kodiakhq bot deleted the fix/nullable-big-number branch February 26, 2024 11:29
This was referenced Feb 26, 2024
Merged
Open
@github-actions github-actions bot mentioned this pull request Mar 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@adrien2p adrien2p Awaiting requested review from adrien2p

@olivermrbl olivermrbl Awaiting requested review from olivermrbl

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riqwan @carlos-r-l-rodrigues