Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add basic CRUD functionality to store module #6510

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

sradevski
Copy link
Member

Adds the core model and basic CRUD around it.

Note: The store model is not complete, but I prefer doing smaller PRs so it's easier to do a proper review. Adding currencies will be a follow-up PR.

@sradevski sradevski requested review from a team as code owners February 26, 2024 12:58
Copy link

changeset-bot bot commented Feb 26, 2024

⚠️ No Changeset found

Latest commit: 31000b1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 1:57pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 26, 2024 1:57pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2024 1:57pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2024 1:57pm

Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🔥

Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one todo 🔥

packages/types/src/store/common/store.ts Outdated Show resolved Hide resolved
@sradevski sradevski force-pushed the feat/add-basic-crud-store branch from 0e01b78 to 31000b1 Compare February 26, 2024 13:53
@kodiakhq kodiakhq bot merged commit b13c669 into develop Feb 26, 2024
17 checks passed
@kodiakhq kodiakhq bot deleted the feat/add-basic-crud-store branch February 26, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants