Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api-key): Add api-key authentication to middleware #6521

Merged
merged 2 commits into from
Feb 27, 2024
Merged

feat(api-key): Add api-key authentication to middleware #6521

merged 2 commits into from
Feb 27, 2024

Conversation

sradevski
Copy link
Member

Also did a bit of a cleanup on the auth middleware. There should be no behavioral changes, just moved code around.

@sradevski sradevski requested review from a team as code owners February 27, 2024 10:54
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 647fb4a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2024 1:18pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 27, 2024 1:18pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2024 1:18pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2024 1:18pm

olivermrbl
olivermrbl approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, clean PR @sradevski. Left a couple of comments.

packages/medusa/src/utils/authenticate-middleware.ts Outdated Show resolved Hide resolved
packages/medusa/src/utils/authenticate-middleware.ts Show resolved Hide resolved
packages/medusa/src/utils/authenticate-middleware.ts Outdated Show resolved Hide resolved
@sradevski sradevski requested a review from pKorsholm February 27, 2024 11:57
@sradevski sradevski force-pushed the feat/enforce-api-key-auth branch from 0f47026 to 4b61adc Compare February 27, 2024 12:07
@sradevski sradevski force-pushed the feat/enforce-api-key-auth branch from 4b61adc to 647fb4a Compare February 27, 2024 13:14
@sradevski
Copy link
Member Author

@olivermrbl please check the last commit for the basic auth approach.

@olivermrbl
Copy link
Contributor

LGTM

@kodiakhq kodiakhq bot merged commit 753bd93 into develop Feb 27, 2024
17 checks passed
@kodiakhq kodiakhq bot deleted the feat/enforce-api-key-auth branch February 27, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@pKorsholm pKorsholm Awaiting requested review from pKorsholm

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sradevski @olivermrbl