Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(utils): Improve big number decorator #6525

Merged
merged 3 commits into from
Feb 27, 2024
Merged

chore(utils): Improve big number decorator #6525

merged 3 commits into from
Feb 27, 2024

Conversation

adrien2p
Copy link
Member

What

  • Re add the ability to use the original column name as part of a select in both select in and joined strategy
  • The undefined error message will now display the original column name instead of the underscored one

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 1185b03

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@adrien2p
Copy link
Member Author

@olivermrbl this should solve your message too

@vercel Vercel
Copy link

vercel bot commented Feb 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2024 1:54pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 27, 2024 1:54pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2024 1:54pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2024 1:54pm

@adrien2p adrien2p marked this pull request as ready for review February 27, 2024 13:47
@adrien2p adrien2p requested review from a team as code owners February 27, 2024 13:47
carlos-r-l-rodrigues
carlos-r-l-rodrigues approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝

@kodiakhq kodiakhq bot merged commit b3d8264 into develop Feb 27, 2024
17 checks passed
@kodiakhq kodiakhq bot deleted the chore/big-number-decorator branch February 27, 2024 15:48
This was referenced Feb 27, 2024
Merged
Open
@github-actions github-actions bot mentioned this pull request Mar 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrien2p @carlos-r-l-rodrigues