Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): Regions domain #6534

Merged
merged 16 commits into from
Feb 29, 2024
Merged

Conversation

kasperkristensen
Copy link
Contributor

@kasperkristensen kasperkristensen commented Feb 28, 2024

What

  • Implements new Region domain design
  • Adds new SplitView component for managing adding nested relations in FocusModals, eg. adding countries to a region.
  • Adds new Combobox component for multi select fields in forms

medusajs/ui

  • Fix styling of RadioGroup.Choicebox component

CLOSES CORE-1650, CORE-1671

@kasperkristensen kasperkristensen requested review from a team as code owners February 28, 2024 14:09
Copy link

changeset-bot bot commented Feb 28, 2024

🦋 Changeset detected

Latest commit: ef72cdd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview Feb 29, 2024 1:02pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 29, 2024 1:02pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 29, 2024 1:02pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 29, 2024 1:02pm

@srindom
Copy link
Collaborator

srindom commented Feb 28, 2024

There's something with long country names that needs some attention:

CleanShot 2024-02-28 at 9  28 20@2x

@srindom
Copy link
Collaborator

srindom commented Feb 28, 2024

If I open the create shipping option modal I am not able to scroll

@srindom
Copy link
Collaborator

srindom commented Feb 28, 2024

Saving doesn't close the modal:

CleanShot 2024-02-28 at 9  32 56

@kasperkristensen
Copy link
Contributor Author

@srindom should be good now

Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit 44a5567 into develop Feb 29, 2024
17 checks passed
@kodiakhq kodiakhq bot deleted the feat/3.0-region-domain-final branch February 29, 2024 13:16
This was referenced Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants