Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tax): add support for updating tax rates #6537

Merged
merged 1 commit into from
Feb 29, 2024
Merged

feat(tax): add support for updating tax rates #6537

merged 1 commit into from
Feb 29, 2024

Conversation

srindom
Copy link
Collaborator

@srindom srindom commented Feb 28, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d659c22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview Feb 29, 2024 10:36am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 29, 2024 10:36am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 29, 2024 10:36am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 29, 2024 10:36am

@srindom srindom force-pushed the feat/tax-v2-api-updates branch from ff50917 to d597931 Compare February 28, 2024 15:35
@srindom srindom changed the base branch from develop to feat/tax-v2-api February 28, 2024 18:53
@srindom srindom marked this pull request as ready for review February 28, 2024 18:53
@srindom srindom requested review from a team as code owners February 28, 2024 18:53
@srindom srindom changed the title Feat/tax v2 api updates feat(tax): add support for updating tax rates Feb 28, 2024
sradevski
sradevski approved these changes Feb 29, 2024
View reviewed changes
packages/tax/src/services/tax-module-service.ts
data: TaxTypes.UpsertTaxRateDTO | TaxTypes.UpsertTaxRateDTO[],
@MedusaContext() sharedContext: Context = {}
): Promise<TaxTypes.TaxRateDTO | TaxTypes.TaxRateDTO[]> {
const result = await this.taxRateService_.upsert(data, sharedContext)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will vary from module to module, but many times we'd like to do some validation and normalization to the input before doing update/create, so calling the internal create_ and update_ methods might be better. It might be fine here though, just wanted to mention it

@srindom srindom changed the base branch from feat/tax-v2-api to develop February 29, 2024 10:26
@srindom srindom force-pushed the feat/tax-v2-api-updates branch from d659c22 to b768770 Compare February 29, 2024 10:31
@kodiakhq kodiakhq bot merged commit 6279fb3 into develop Feb 29, 2024
17 checks passed
@kodiakhq kodiakhq bot deleted the feat/tax-v2-api-updates branch February 29, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sradevski sradevski sradevski approved these changes

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srindom @sradevski