Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix docs PR label removing team label #7308

Merged
merged 3 commits into from
May 13, 2024

Conversation

shahednasser
Copy link
Member

@shahednasser shahednasser commented May 13, 2024

Add the team labeler action as a step in the docs PR labeler action since it removes the team label.

We can alternatively move the docs PR labeler to the team labeler action to run before it. Let me know if you prefer that fix

Edit: Ended up following the second approach as it's more scalable if we decide to support more labels

@shahednasser shahednasser requested a review from a team as a code owner May 13, 2024 09:48
Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 0:48am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) May 13, 2024 0:48am
docs-ui ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 0:48am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 0:48am

Copy link

changeset-bot bot commented May 13, 2024

⚠️ No Changeset found

Latest commit: 415564c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@shahednasser shahednasser merged commit 8958214 into develop May 13, 2024
17 checks passed
@shahednasser shahednasser deleted the chore/fix-pr-labeler branch May 13, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants