Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Filesystem test util and load env util #7487

Merged
merged 25 commits into from
May 28, 2024
Merged

Add Filesystem test util and load env util #7487

merged 25 commits into from
May 28, 2024

Conversation

thetutlage
Copy link
Contributor

To get things going, this PR adds the loadEnv utility function and a FileSystem class to create and remove temporary files during tests

@thetutlage thetutlage requested a review from a team as a code owner May 28, 2024 04:28
@thetutlage thetutlage requested review from riqwan, fPolic and adrien2p May 28, 2024 04:28
@vercel Vercel
Copy link

vercel bot commented May 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 9:22am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) May 28, 2024 9:22am
docs-ui ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 9:22am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 9:22am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 768ac86

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

adrien2p
adrien2p approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like the approach 🤘
Only the tests to fix

@thetutlage
Copy link
Contributor Author

@adrien2p No idea why they are failing. Asked the same in Slack

@thetutlage thetutlage requested a review from a team as a code owner May 28, 2024 06:52
@thetutlage
Copy link
Contributor Author

I did not manually bump them. Maybe yarn install has pulled the recent versions. But yes, I did remove the yarn.lock file as I was getting some version errors.

@thetutlage
Copy link
Contributor Author

What an adventure this PR has been 😇

@thetutlage
Copy link
Contributor Author

I am sure that my lock file pulled in some dependencies which were causing this issue. I am using the yarn.lock file from develop branch now. Let's see how it goes.

@adrien2p
Copy link
Member

I am sure that my lock file pulled in some dependencies which were causing this issue. I am using the yarn.lock file from develop branch now. Let's see how it goes.

You might get some issues doing that as you have moved around some deps that are not part if the develop yarn.lock 🫣

@thetutlage
Copy link
Contributor Author

@adrien2p @sradevski . Okay now tests are passing, can you please give it a final look and see if everything is fine :)

@thetutlage
Copy link
Contributor Author

/snapshot-this

@thetutlage thetutlage merged commit ef6d748 into develop May 28, 2024
17 checks passed
@thetutlage thetutlage deleted the feat/utilities-for-medusa-config branch May 28, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien2p adrien2p adrien2p approved these changes

@sradevski sradevski sradevski left review comments

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thetutlage @olivermrbl @adrien2p @sradevski @carlos-r-l-rodrigues