Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename config properties to camelCase #7498

Merged
merged 5 commits into from
May 28, 2024

Conversation

thetutlage
Copy link
Contributor

@thetutlage thetutlage commented May 28, 2024

Renaming config properties to be camel case.

Side note: Not able to run build on the local. So the only option I have is to push changes and use the CI as the only feedback channel.

@thetutlage thetutlage requested a review from a team as a code owner May 28, 2024 11:11
Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 0:32am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) May 28, 2024 0:32am
docs-ui ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 0:32am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 0:32am

Copy link

changeset-bot bot commented May 28, 2024

⚠️ No Changeset found

Latest commit: 4a37cee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, did you go through the entire code base?

@thetutlage thetutlage requested review from a team and kasperkristensen and removed request for a team May 28, 2024 11:19
@olivermrbl olivermrbl changed the title Rename config types to camelCase chore: Rename config types to camelCase May 28, 2024
@olivermrbl olivermrbl changed the title chore: Rename config types to camelCase chore: Rename config properties to camelCase May 28, 2024
@olivermrbl olivermrbl merged commit 82be054 into develop May 28, 2024
25 checks passed
@olivermrbl olivermrbl deleted the refactor/config-props-to-camelcase branch May 28, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants