Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure sales channel updates don't remove sales channel on other products #7510

Merged
merged 2 commits into from
May 28, 2024
Merged

Ensure sales channel updates don't remove sales channel on other products #7510

merged 2 commits into from
May 28, 2024

Conversation

sradevski
Copy link
Member

No description provided.

@sradevski sradevski requested a review from a team as a code owner May 28, 2024 15:48
@vercel Vercel
Copy link

vercel bot commented May 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 3:57pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) May 28, 2024 3:57pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 3:57pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 3:57pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 70e6109

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

adrien2p
adrien2p reviewed May 28, 2024
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we remove all inventory_quantity? It seems unrelated to the pr scope no?

packages/core/core-flows/src/product/workflows/update-products.ts Outdated Show resolved Hide resolved
packages/core/core-flows/src/product/workflows/update-products.ts Outdated Show resolved Hide resolved
@sradevski sradevski force-pushed the fix/update-sales-channel-product branch from 5e6753a to 70e6109 Compare May 28, 2024 15:56
@sradevski
Copy link
Member Author

@adrien2p they were already removed everywhere else, it's just that they were not removed in the api tests. The tests were failing because of that.

adrien2p
adrien2p approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be good for me 👍

@olivermrbl olivermrbl merged commit af7a885 into develop May 28, 2024
17 checks passed
@olivermrbl olivermrbl deleted the fix/update-sales-channel-product branch May 28, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@adrien2p adrien2p adrien2p approved these changes

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sradevski @adrien2p @carlos-r-l-rodrigues @olivermrbl