Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-ui): Fixed DropdownMenu inside a Modal zIndex issues #8358

Conversation

adevinwild
Copy link
Contributor

@adevinwild adevinwild commented Jul 30, 2024

Related issue

This PR is related to this issue #8158

What

This PR make sure to render the DropdownMenu in a React Portal to solves any issues when you have a DropdownMenu inside a Modal

  • This is a common issue with RadixUI the solution is to use a Portal to make sure the DropdownMenu is rendered on the document.body instead of the same container
  • Updated the zIndex from z-30 to z-50
image

- This is a common issue with RadixUI the solution is to use a Portal to make sure the DropdownMenu is rendered on the `document.body` instead of the same container
- Updated the zIndex from `z-30` to `z-50`
@adevinwild adevinwild requested a review from a team as a code owner July 30, 2024 21:06
Copy link

changeset-bot bot commented Jul 30, 2024

⚠️ No Changeset found

Latest commit: 8f0dd0d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 30, 2024

Someone is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@kasperkristensen kasperkristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @adevinwild

@kasperkristensen kasperkristensen merged commit be654e6 into medusajs:v1.x Jul 31, 2024
19 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants