You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part two of bulk editor improvements, mainly focussed on adding special behaviours for the Boolean cell.
Changes to the Boolean cell
Boolean cells no longer require a double click or "Enter" key press before being interactive.
Boolean cells now invert when focused and the user hits "Space".
If a range of boolean cells are selected hitting "Space" will do the following:
If all fields are either true or false then invert the values.
If some fields are true and others are false, then set all fields to true.
Hitting "Enter" on a Boolean cell will invert its value, and then move focus to the next row. This is not the same behaviour, as you would find in a spreadsheet like Google Sheets. Their hitting enter shows the underlying text value, e.g. "FALSE". We don't have a underlying text value, that we allow users to edit, so instead I opted for the described behaviour, which allows the user to toggle cells in quick succession.
Changes to scroll behaviour
We now attempt to scroll to the next row/column if possible. This overscroll provides a more smooth experience, as it allows the virtualizer to load the next couple of rows/columns even if the cell we are currently scrolling to is at the edge of the screen.
Changes to how selection and dragSelection is calculated
The useEffect's that were used to update the selection / drag selection on updates to anchor, rangeEnd, and dragEnd have been removed in favour of utils that a cell can call to check if it is in either selection.
Clean up of query selector use
A new hook useGridQueryTool has been added that exposes a couple of utils for getting a cell container or cell input HTML element.
Other
Adds prop-types dependency to project. This should prevent an error being thrown about the dependency missing when running the dashboard in development. This is might temporary, as the current FocusTrap solution is not perfect and needs to be improved. Not sure yet, if the desired effect can be achieved with focus-trap-react, but if not we will remove the dependency and prop-types.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kasperkristensen
changed the title
What
Changes to the Boolean cell
Changes to scroll behaviour
Changes to how selection and dragSelection is calculated
useEffect's that were used to update the selection / drag selection on updates toanchor,rangeEnd, anddragEndhave been removed in favour of utils that a cell can call to check if it is in either selection.Clean up of query selector use
useGridQueryToolhas been added that exposes a couple of utils for getting a cell container or cell input HTML element.Other
prop-typesdependency to project. This should prevent an error being thrown about the dependency missing when running the dashboard in development. This is might temporary, as the current FocusTrap solution is not perfect and needs to be improved. Not sure yet, if the desired effect can be achieved withfocus-trap-react, but if not we will remove the dependency andprop-types.Closes CC-268