Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-flows): manage inventory reservation of claims and exchanges #8448

Merged
merged 18 commits into from
Aug 7, 2024

Conversation

carlos-r-l-rodrigues
Copy link
Contributor

No description provided.

@carlos-r-l-rodrigues carlos-r-l-rodrigues requested a review from a team as a code owner August 5, 2024 11:17
@carlos-r-l-rodrigues carlos-r-l-rodrigues requested review from riqwan, adrien2p and olivermrbl and removed request for a team August 5, 2024 11:17
Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 8:07pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Aug 6, 2024 8:07pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 8:07pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 8:07pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 8:07pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 8:07pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 8:07pm

Copy link

changeset-bot bot commented Aug 5, 2024

⚠️ No Changeset found

Latest commit: 3a5cc97

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@carlos-r-l-rodrigues carlos-r-l-rodrigues changed the base branch from chore/order-exchange-2 to develop August 6, 2024 09:28
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +114 to +118
when({ input }, ({ input }) => {
return !input.skipInventoryCheck
}).then(() => {
confirmInventoryStep(confirmInventoryInput)
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Does it make sense for this check to live inside the confirmVariantInventoryWorkflow? Shouldn't it be outside of it when you consume it?

Copy link
Contributor Author

@carlos-r-l-rodrigues carlos-r-l-rodrigues Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this is a good point.
I think it makes sense to separate in a util the portion to format the input to confirm/reserve inventory, from the inventory check.
I will open a follow up PR organizing that.

@carlos-r-l-rodrigues carlos-r-l-rodrigues merged commit 1fb679e into develop Aug 7, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants