Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs-util: fix update OAS schema #8556

Merged
merged 4 commits into from
Aug 16, 2024
Merged

docs-util: fix update OAS schema #8556

merged 4 commits into from
Aug 16, 2024

Conversation

shahednasser
Copy link
Member

  • Fix updating an OAS schema when the types are completely different, or when the length of allOf/anyOf/oneOf arrays are different.
  • Added description for additional_data to knowledge base.

@shahednasser shahednasser requested a review from a team as a code owner August 12, 2024 10:19
@vercel Vercel
Copy link

vercel bot commented Aug 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 10:17am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 10:17am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 10:17am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 10:17am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 10:17am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 10:17am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 10:17am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0cdcb08

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

carlos-r-l-rodrigues
carlos-r-l-rodrigues approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

www/utils/packages/docs-generator/src/classes/kinds/oas.ts Outdated Show resolved Hide resolved
@shahednasser
Copy link
Member Author

@olivermrbl can we get this one in?

@shahednasser shahednasser merged commit f0f83af into develop Aug 16, 2024
31 checks passed
@shahednasser shahednasser deleted the docs-util/fix-oas-update branch August 16, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

Assignees
No one assigned
Labels
team: medusa type: docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shahednasser @carlos-r-l-rodrigues @olivermrbl