Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move userpass default definition to defineConfig instead of a hard-coded value #8557

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

sradevski
Copy link
Member

@sradevski sradevski commented Aug 12, 2024

medusajs/medusa-starter-default#1408 should be merged first.

FIXES #8452
CLOSES CC-334

@sradevski sradevski requested a review from a team as a code owner August 12, 2024 10:32
Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 8:13am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Aug 13, 2024 8:13am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 8:13am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 8:13am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 8:13am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 8:13am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 8:13am

Copy link

changeset-bot bot commented Aug 12, 2024

🦋 Changeset detected

Latest commit: a91b269

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@medusajs/auth Patch
@medusajs/utils Patch
@medusajs/auth-emailpass Patch
integration-tests-http Patch
@medusajs/promotion Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sradevski
Copy link
Member Author

/snapshot-this

@carlos-r-l-rodrigues
Copy link
Contributor

you might need a changeset

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – nice one

@olivermrbl olivermrbl merged commit a013c4e into develop Aug 13, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants