Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): Check for displaying placeholder value #8649

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

kasperkristensen
Copy link
Contributor

What

  • Fixes an issue that would prevent the placeholder value from being shown when value === ""

@kasperkristensen kasperkristensen requested a review from a team as a code owner August 19, 2024 08:02
Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 8:03am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Aug 19, 2024 8:03am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 19, 2024 8:03am
docs-ui ⬜️ Ignored (Inspect) Aug 19, 2024 8:03am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 19, 2024 8:03am
medusa-docs ⬜️ Ignored (Inspect) Aug 19, 2024 8:03am
resources-docs ⬜️ Ignored (Inspect) Aug 19, 2024 8:03am

Copy link

changeset-bot bot commented Aug 19, 2024

⚠️ No Changeset found

Latest commit: 9504247

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kasperkristensen kasperkristensen changed the title fix check for displaying placeholder value fix(dashboard): Check for displaying placeholder value Aug 19, 2024
@kasperkristensen kasperkristensen merged commit cbdec98 into develop Aug 19, 2024
23 checks passed
@kasperkristensen kasperkristensen deleted the fix/country-select-placeholder-check branch August 19, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants