Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(payment-stripe): fix smallest unit calculation #8663

Merged
merged 1 commit into from
Aug 19, 2024
Merged

fix(payment-stripe): fix smallest unit calculation #8663

merged 1 commit into from
Aug 19, 2024

Conversation

carlos-r-l-rodrigues
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues commented Aug 19, 2024 •
edited
Loading

FIXES: CC-342

#8640

@carlos-r-l-rodrigues carlos-r-l-rodrigues requested a review from a team as a code owner August 19, 2024 15:37
@vercel Vercel
Copy link

vercel bot commented Aug 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 3:45pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 3:45pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 19, 2024 3:45pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Aug 19, 2024 3:45pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 19, 2024 3:45pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 19, 2024 3:45pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Aug 19, 2024 3:45pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2024

⚠️ No Changeset found

Latest commit: c30979a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

olivermrbl
olivermrbl approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olivermrbl olivermrbl merged commit dd82a56 into develop Aug 19, 2024
23 checks passed
@olivermrbl olivermrbl deleted the fix/stripe-smallest-unit branch August 19, 2024 17:19
@420coupe
Copy link
Contributor

420coupe commented Aug 19, 2024 •
edited
Loading

edited.

Ignore PR works correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlos-r-l-rodrigues @420coupe @olivermrbl