Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): Wrap each route in an ErrorBoundary #8674

Merged
merged 5 commits into from
Aug 20, 2024

Conversation

kasperkristensen
Copy link
Contributor

@kasperkristensen kasperkristensen commented Aug 20, 2024

What

  • Updates the copy of the different error types
  • Wraps each route (+ custom routes) in an ErrorBoundary to preserve app layout on error (sidebar and topbar)

Skærmbillede 2024-08-20 kl  12 35 53

Note
If the user goes to a route that does not exist at all, e.g. /some-weird-url, then we have no way of knowing if the user is inside of a context where we can render the sidebar and topbar (as they require the user to be authenticated). So in this case we still show an ErrorBoundary where the two aren't included (see second picture), and include a button that takes the user to "/", which depending on whether the user is logged in will take them to "/login" or "/orders".

image

Resolves CC-248

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 1:02pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 1:02pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 1:02pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 1:02pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 1:02pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 1:02pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 1:02pm

Copy link

changeset-bot bot commented Aug 20, 2024

⚠️ No Changeset found

Latest commit: 398e1db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in this case we still show an ErrorBoundary where the two aren't included (see second picture), and include a button that takes the user to "/", which depending on whether the user is logged in will take them to "/login" or "/orders".

Nice, sounds like a good solution.

@kodiakhq kodiakhq bot merged commit 3706bf5 into develop Aug 20, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the feat/improved-error-boundary branch August 20, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants